Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue 5567 #5590

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

ptomulik
Copy link
Contributor

Closes #5567

(hopefully).

@ptomulik ptomulik mentioned this pull request Nov 30, 2023
@sebastianbergmann
Copy link
Owner

@staabm Can you have a look at if/how this affects performance? Thanks!

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5d9dca) 88.47% compared to head (b26e53a) 88.29%.

❗ Current head b26e53a differs from pull request most recent head 82a274f. Consider uploading reports for the commit 82a274f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               10.5    #5590      +/-   ##
============================================
- Coverage     88.47%   88.29%   -0.18%     
- Complexity     6367     6369       +2     
============================================
  Files           679      679              
  Lines         20313    20319       +6     
============================================
- Hits          17971    17940      -31     
- Misses         2342     2379      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@staabm
Copy link
Contributor

staabm commented Nov 30, 2023

I can have a look within a few days.

@sebastianbergmann sebastianbergmann added the type/bug Something is broken label Dec 1, 2023
@staabm
Copy link
Contributor

staabm commented Dec 3, 2023

I had a look and I don't see something particular interessting perf wise. @sebastianbergmann did you have something special in mind?

@sebastianbergmann
Copy link
Owner

I had a look and I don't see something particular interessting perf wise. @sebastianbergmann did you have something special in mind?

The isScalarOrArrayOfScalars() method is used to determine whether or not the expensive operation of exporting non-scalar value is performed or not.

If you do not not see an obvious performance issue: great! Thank you for looking into this.

@sebastianbergmann sebastianbergmann merged commit 6db6de5 into sebastianbergmann:10.5 Dec 4, 2023
29 checks passed
@ptomulik ptomulik deleted the issue-5567 branch December 11, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants